Skip to content

Use return scope in ScopedBuffer members #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use return scope in ScopedBuffer members #376

wants to merge 1 commit into from

Conversation

nordlow
Copy link
Contributor

@nordlow nordlow commented Dec 5, 2021 •
edited
Loading

If you return a reference to a this field you should qualify as return scope instead of just scope in order for scope-analys to work on values returned from these members of ScopedBuffer.

@9il
Copy link
Member

9il commented Dec 6, 2021 •
edited
Loading

tests fail

@nordlow
Copy link
Contributor Author

nordlow commented Dec 7, 2021

I'm cluess about these errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nordlow @9il